Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add on click to update applied on date #81

Merged
merged 14 commits into from
Feb 14, 2025

Conversation

dcardona23
Copy link
Collaborator

@dcardona23 dcardona23 commented Feb 7, 2025

Type of Change

  • feature β›²
  • refactor πŸ§‘β€πŸ’»
  • testing πŸ§ͺ

Description

This PR adds on-click functionality to edit an application date by clicking the applied on date on an application show page. It also adds Cypress tests to confirm functionality, including that the application is updating in the backend so the changes persist.

This PR also makes minor styling updates to the job application show page to align with changes made to the contacts page.

Note - because I added the DatePicker component and moment library, I believe the team will need to run npm install after pulling down these changes.

Motivation and Context

This change allows a user to change an application date from the application show page without clicking on the "Edit" button to edit the application.

Closes issue #96.

Related Tickets

Screenshots (if appropriate):

Added Test?

  • Yes 🫑
    • Integration tests added
    • Because of the current issue with users being logged out upon page refresh, I had to modify a few other Cypress tests by adding additional intercepts.
  • No πŸ™…
  • All previous tests still pass πŸ₯³

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@MiTOBrien MiTOBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, code looks clean and well written.

Copy link
Collaborator

@wally-yawn wally-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling this down and testing locally shows that this doesn't actually save the change when you navigate away from the page. Is there another issue to implement that save?

Copy link
Collaborator

@TDManning TDManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for edits to handleSave function and a possible cypress test to ensure the backend is saving the modified user input

Copy link
Collaborator

@TDManning TDManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on all of these updates and changes. This code is looking clean and the function is well implemented.

@epintozzi epintozzi requested a review from wally-yawn February 14, 2025 20:43
Copy link
Collaborator

@wally-yawn wally-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I'll go ahead and merge this and check it on heroku

@wally-yawn wally-yawn merged commit 2d02c6e into main Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants