-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add on click to update applied on date #81
Feat/add on click to update applied on date #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, code looks clean and well written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling this down and testing locally shows that this doesn't actually save the change when you navigate away from the page. Is there another issue to implement that save?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for edits to handleSave function and a possible cypress test to ensure the backend is saving the modified user input
β¦at/add-on-click-to-update-applied-on-date
β¦at/add-on-click-to-update-applied-on-date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on all of these updates and changes. This code is looking clean and the function is well implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I'll go ahead and merge this and check it on heroku
Type of Change
Description
This PR adds on-click functionality to edit an application date by clicking the applied on date on an application show page. It also adds Cypress tests to confirm functionality, including that the application is updating in the backend so the changes persist.
This PR also makes minor styling updates to the job application show page to align with changes made to the contacts page.
Note - because I added the DatePicker component and moment library, I believe the team will need to run npm install after pulling down these changes.
Motivation and Context
This change allows a user to change an application date from the application show page without clicking on the "Edit" button to edit the application.
Closes issue #96.
Related Tickets
Screenshots (if appropriate):
Added Test?
Checklist: